aboutsummaryrefslogtreecommitdiff
path: root/lib/mpi/mpi-sub-ui.c
diff options
context:
space:
mode:
authorVishal Verma <[email protected]>2022-11-16 16:37:37 -0700
committerDan Williams <[email protected]>2022-11-18 23:55:40 -0800
commit48d4180939e12c4bd2846f984436d895bb9699ed (patch)
tree30a105ea3bbea28a4bb48626503f4fe1faab3920 /lib/mpi/mpi-sub-ui.c
parent14f16d47561ba9249efc6c2db9d47ed56841f070 (diff)
ACPI: HMAT: Fix initiator registration for single-initiator systems
In a system with a single initiator node, and one or more memory-only 'target' nodes, the memory-only node(s) would fail to register their initiator node correctly. i.e. in sysfs: # ls /sys/devices/system/node/node0/access0/targets/ node0 Where as the correct behavior should be: # ls /sys/devices/system/node/node0/access0/targets/ node0 node1 This happened because hmat_register_target_initiators() uses list_sort() to sort the initiator list, but the sort comparision function (initiator_cmp()) is overloaded to also set the node mask's bits. In a system with a single initiator, the list is singular, and list_sort elides the comparision helper call. Thus the node mask never gets set, and the subsequent search for the best initiator comes up empty. Add a new helper to consume the sorted initiator list, and generate the nodemask, decoupling it from the overloaded initiator_cmp() comparision callback. This prevents the singular list corner case naturally, and makes the code easier to follow as well. Cc: <[email protected]> Cc: Rafael J. Wysocki <[email protected]> Cc: Liu Shixin <[email protected]> Cc: Dan Williams <[email protected]> Cc: Kirill A. Shutemov <[email protected]> Reported-by: Chris Piper <[email protected]> Signed-off-by: Vishal Verma <[email protected]> Acked-by: Rafael J. Wysocki <[email protected]> Acked-by: Kirill A. Shutemov <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Dan Williams <[email protected]>
Diffstat (limited to 'lib/mpi/mpi-sub-ui.c')
0 files changed, 0 insertions, 0 deletions