diff options
author | Geert Uytterhoeven <[email protected]> | 2023-06-05 04:09:27 +1000 |
---|---|---|
committer | Dave Chinner <[email protected]> | 2023-06-05 04:09:27 +1000 |
commit | 4320f34666363e202f8c290869c2d78c1ce9f3f1 (patch) | |
tree | d040167009790ca121bb2e69db731006794b55ed /lib/mpi/mpi-sub-ui.c | |
parent | 82842fee6e5979ca7e2bf4d839ef890c22ffb7aa (diff) |
xfs: Fix undefined behavior of shift into sign bit
With gcc-5:
In file included from ./include/trace/define_trace.h:102:0,
from ./fs/xfs/scrub/trace.h:988,
from fs/xfs/scrub/trace.c:40:
./fs/xfs/./scrub/trace.h: In function ‘trace_raw_output_xchk_fsgate_class’:
./fs/xfs/scrub/scrub.h:111:28: error: initializer element is not constant
#define XREP_ALREADY_FIXED (1 << 31) /* checking our repair work */
^
Shifting the (signed) value 1 into the sign bit is undefined behavior.
Fix this for all definitions in the file by shifting "1U" instead of
"1".
This was exposed by the first user added in commit 466c525d6d35e691
("xfs: minimize overhead of drain wakeups by using jump labels").
Fixes: 160b5a784525e8a4 ("xfs: hoist the already_fixed variable to the scrub context")
Signed-off-by: Geert Uytterhoeven <[email protected]>
Reviewed-by: Darrick J. Wong <[email protected]>
Signed-off-by: Dave Chinner <[email protected]>
Diffstat (limited to 'lib/mpi/mpi-sub-ui.c')
0 files changed, 0 insertions, 0 deletions