diff options
| author | Avi Fishman <[email protected]> | 2019-07-29 20:03:54 +0300 |
|---|---|---|
| committer | Daniel Lezcano <[email protected]> | 2019-08-27 00:31:39 +0200 |
| commit | a2b58537b4a1cc08fd254fb8d1c24191ce286ae1 (patch) | |
| tree | 3ef3aecfc971902ba3b744c0b3542b4180e5fa2a /lib/mpi/mpi-mul.c | |
| parent | 8d18f6fc75c86b2efa5865655a0630a083c8a1fd (diff) | |
clocksource/drivers/npcm: Fix GENMASK and timer operation
NPCM7XX_Tx_OPER GENMASK bits are wrong, fix them.
Hopefully the NPCM7XX_REG_TICR0 register reset value of those bits was 0,
so it did not cause an issue.
The function npcm7xx_timer_oneshot() reads the register
NPCM7XX_REG_TCSR0, modifies it and then reads it again overwriting the
previous changes. Remove the extra read which is pointless.
The function npcm7xx_timer_periodic() is correct but the code writes
to the NPCM7XX_REG_TICR0 register while it is dealing with the
NPCM7XX_REG_TCSR0 register, that is confusing. Separate the write to
the registers in the code for the sake of clarity.
Fixes: 1c00289ecd12 ("clocksource/drivers/npcm: Add NPCM7xx timer driver")
Signed-off-by: Avi Fishman <[email protected]>
Signed-off-by: Daniel Lezcano <[email protected]>
Diffstat (limited to 'lib/mpi/mpi-mul.c')
0 files changed, 0 insertions, 0 deletions