diff options
| author | Andy Shevchenko <[email protected]> | 2017-12-28 14:25:23 +0200 |
|---|---|---|
| committer | Ingo Molnar <[email protected]> | 2018-01-08 20:01:44 +0100 |
| commit | 9d0513d82f1a8fe17b41f113ac5922fa57dbaf5c (patch) | |
| tree | 145a8b0de384b24243a98baf76588cd611ed857e /lib/mpi/mpi-mul.c | |
| parent | b94b7373317164402ff7728d10f7023127a02b60 (diff) | |
x86/platform/intel-mid: Revert "Make 'bt_sfi_data' const"
So one of the constification patches unearthed a type casting fragility
of the underlying code:
276c87054751 ("x86/platform/intel-mid: Make 'bt_sfi_data' const")
converted the struct to be const while it is also used as a temporary
container for important data that is used to fill 'parent' and 'name'
fields in struct platform_device_info.
The compiler doesn't notice this due to an explicit type cast that loses
the const - which fragility will be fixed separately.
This type cast turned a seemingly trivial const propagation patch into a
hard to debug data corruptor and crasher bug.
Signed-off-by: Andy Shevchenko <[email protected]>
Cc: Bhumika Goyal <[email protected]>
Cc: Darren Hart <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: [email protected]
Cc: [email protected]
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
Diffstat (limited to 'lib/mpi/mpi-mul.c')
0 files changed, 0 insertions, 0 deletions