diff options
| author | Christoph Böhmwalder <[email protected]> | 2023-05-03 14:19:37 +0200 |
|---|---|---|
| committer | Jens Axboe <[email protected]> | 2023-05-03 09:36:56 -0600 |
| commit | 3899d94e3831ee07ea6821c032dc297aec80586a (patch) | |
| tree | 6a73e2d3a675154ebb98e75b8143f656a1d6f78a /lib/mpi/mpi-mul.c | |
| parent | 7949aa46bb4b5c5e43ba3ba8298ffcb48bebf0ff (diff) | |
drbd: correctly submit flush bio on barrier
When we receive a flush command (or "barrier" in DRBD), we currently use
a REQ_OP_FLUSH with the REQ_PREFLUSH flag set.
The correct way to submit a flush bio is by using a REQ_OP_WRITE without
any data, and set the REQ_PREFLUSH flag.
Since commit b4a6bb3a67aa ("block: add a sanity check for non-write
flush/fua bios"), this triggers a warning in the block layer, but this
has been broken for quite some time before that.
So use the correct set of flags to actually make the flush happen.
Cc: Christoph Hellwig <[email protected]>
Cc: [email protected]
Fixes: f9ff0da56437 ("drbd: allow parallel flushes for multi-volume resources")
Reported-by: Thomas Voegtle <[email protected]>
Signed-off-by: Christoph Böhmwalder <[email protected]>
Reviewed-by: Christoph Hellwig <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jens Axboe <[email protected]>
Diffstat (limited to 'lib/mpi/mpi-mul.c')
0 files changed, 0 insertions, 0 deletions