diff options
author | Maurizio Lombardi <mlombard@redhat.com> | 2023-01-27 16:42:37 +0100 |
---|---|---|
committer | Christoph Hellwig <hch@lst.de> | 2023-02-01 14:18:46 +0100 |
commit | fd62678ab55cb01e11a404d302cdade222bf4022 (patch) | |
tree | c20351bc08526ced74526ad304c4b54546e70bad /lib/mpi/mpi-cmp.c | |
parent | 0cab4404874f2de52617de8400c844891c6ea1ce (diff) |
nvme: clear the request_queue pointers on failure in nvme_alloc_admin_tag_set
If nvme_alloc_admin_tag_set() fails, the admin_q and fabrics_q pointers
are left with an invalid, non-NULL value. Other functions may then check
the pointers and dereference them, e.g. in
nvme_probe() -> out_disable: -> nvme_dev_remove_admin().
Fix the bug by setting admin_q and fabrics_q to NULL in case of error.
Also use the set variable to free the tag_set as ctrl->admin_tagset isn't
initialized yet.
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'lib/mpi/mpi-cmp.c')
0 files changed, 0 insertions, 0 deletions