diff options
author | Ian Abbott <[email protected]> | 2020-07-17 15:52:57 +0100 |
---|---|---|
committer | Greg Kroah-Hartman <[email protected]> | 2020-07-20 10:19:02 +0200 |
commit | fc846e9db67c7e808d77bf9e2ef3d49e3820ce5d (patch) | |
tree | 6ff4f7d67ddb90ff84b29652b85d4834f318d66f /lib/mpi/mpi-cmp.c | |
parent | 0bd0db42a030b75c20028c7ba6e327b9cb554116 (diff) |
staging: comedi: addi_apci_1500: check INSN_CONFIG_DIGITAL_TRIG shift
The `INSN_CONFIG` comedi instruction with sub-instruction code
`INSN_CONFIG_DIGITAL_TRIG` includes a base channel in `data[3]`. This is
used as a right shift amount for other bitmask values without being
checked. Shift amounts greater than or equal to 32 will result in
undefined behavior. Add code to deal with this, adjusting the checks
for invalid channels so that enabled channel bits that would have been
lost by shifting are also checked for validity. Only channels 0 to 15
are valid.
Fixes: a8c66b684efaf ("staging: comedi: addi_apci_1500: rewrite the subdevice support functions")
Cc: <[email protected]> #4.0+: ef75e14a6c93: staging: comedi: verify array index is correct before using it
Cc: <[email protected]> #4.0+
Signed-off-by: Ian Abbott <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'lib/mpi/mpi-cmp.c')
0 files changed, 0 insertions, 0 deletions