diff options
author | Chris Wilson <[email protected]> | 2013-12-04 11:37:09 +0000 |
---|---|---|
committer | Daniel Vetter <[email protected]> | 2013-12-12 10:49:05 +0100 |
commit | 4db080f9e93411c3c41ec402244da28e2bbde835 (patch) | |
tree | 6491769be6090a1e3ae93a564e1bcd9951b6f861 /lib/mpi/mpi-cmp.c | |
parent | 9ae9ab522094406915c27dc729d3ecef7b44af72 (diff) |
drm/i915: Fix erroneous dereference of batch_obj inside reset_status
As the rings may be processed and their requests deallocated in a
different order to the natural retirement during a reset,
/* Whilst this request exists, batch_obj will be on the
* active_list, and so will hold the active reference. Only when this
* request is retired will the the batch_obj be moved onto the
* inactive_list and lose its active reference. Hence we do not need
* to explicitly hold another reference here.
*/
is violated, and the batch_obj may be dereferenced after it had been
freed on another ring. This can be simply avoided by processing the
status update prior to deallocating any requests.
Fixes regression (a possible OOPS following a GPU hang) from
commit aa60c664e6df502578454621c3a9b1f087ff8d25
Author: Mika Kuoppala <[email protected]>
Date: Wed Jun 12 15:13:20 2013 +0300
drm/i915: find guilty batch buffer on ring resets
Signed-off-by: Chris Wilson <[email protected]>
Cc: Mika Kuoppala <[email protected]>
Cc: [email protected]
Reviewed-by: Mika Kuoppala <[email protected]>
[danvet: Add the code comment Chris supplied.]
Signed-off-by: Daniel Vetter <[email protected]>
Diffstat (limited to 'lib/mpi/mpi-cmp.c')
0 files changed, 0 insertions, 0 deletions