diff options
| author | Helmut Grohne <[email protected]> | 2020-07-21 13:07:39 +0200 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2020-07-21 15:50:02 -0700 |
| commit | 3506b2f42dff66ea6814c3dfa1988bafb79e6f88 (patch) | |
| tree | a49666fb13d650c62a12cec91a5c30283ff125da /lib/mpi/mpi-cmp.c | |
| parent | 2dc3bd74d7214914fa911a9772fb5ed1164707bf (diff) | |
net: dsa: microchip: call phy_remove_link_mode during probe
When doing "ip link set dev ... up" for a ksz9477 backed link,
ksz9477_phy_setup is called and it calls phy_remove_link_mode to remove
1000baseT HDX. During phy_remove_link_mode, phy_advertise_supported is
called. Doing so reverts any previous change to advertised link modes
e.g. using a udevd .link file.
phy_remove_link_mode is not meant to be used while opening a link and
should be called during phy probe when the link is not yet available to
userspace.
Therefore move the phy_remove_link_mode calls into
ksz9477_switch_register. It indirectly calls dsa_register_switch, which
creates the relevant struct phy_devices and we update the link modes
right after that. At that time dev->features is already initialized by
ksz9477_switch_detect.
Remove phy_setup from ksz_dev_ops as no users remain.
Link: https://lore.kernel.org/netdev/[email protected]/
Fixes: 42fc6a4c613019 ("net: dsa: microchip: prepare PHY for proper advertisement")
Signed-off-by: Helmut Grohne <[email protected]>
Reviewed-by: Andrew Lunn <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'lib/mpi/mpi-cmp.c')
0 files changed, 0 insertions, 0 deletions