diff options
author | Hendrik Brueckner <[email protected]> | 2017-06-20 12:26:39 +0200 |
---|---|---|
committer | Ingo Molnar <[email protected]> | 2017-06-21 11:58:30 +0200 |
commit | 8a1898db51a3390241cd5fae267dc8aaa9db0f8b (patch) | |
tree | af5992171da843c26f3a072e1fab03b261adf9fb /lib/mpi/mpi-bit.c | |
parent | 9705596d08ac87c18aee32cc97f2783b7d14624e (diff) |
perf/aux: Correct return code of rb_alloc_aux() if !has_aux(ev)
If the event for which an AUX area is about to be allocated, does
not support setting up an AUX area, rb_alloc_aux() return -ENOTSUPP.
This error condition is being returned unfiltered to the user space,
and, for example, the perf tools fails with:
failed to mmap with 524 (INTERNAL ERROR: strerror_r(524, 0x3fff497a1c8, 512)=22)
This error can be easily seen with "perf record -m 128,256 -e cpu-clock".
The 524 error code maps to -ENOTSUPP (in rb_alloc_aux()). The -ENOTSUPP
error code shall be only used within the kernel. So the correct error
code would then be -EOPNOTSUPP.
With this commit, the perf tool then reports:
failed to mmap with 95 (Operation not supported)
which is more clear.
Signed-off-by: Hendrik Brueckner <[email protected]>
Acked-by: Alexander Shishkin <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Pu Hou <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Thomas-Mich Richter <[email protected]>
Cc: [email protected]
Cc: [email protected]
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
Diffstat (limited to 'lib/mpi/mpi-bit.c')
0 files changed, 0 insertions, 0 deletions