diff options
| author | Linus Walleij <[email protected]> | 2019-12-05 00:32:30 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2019-12-10 10:56:53 +0100 |
| commit | 453a4b6d8e1bdff2b8e1f56f4b8a8ef6d36b0e77 (patch) | |
| tree | f73ac7fe244e18d761349b8a0fae806119c72fd3 /lib/mpi/mpi-bit.c | |
| parent | 1184fd9966702a5a1cea73bdb6fe646b961c387c (diff) | |
staging: fbtft: Do not hardcode SPI CS polarity inversion
The current use of the mode flag SPI_CS_HIGH is fragile: it
overwrites anything already assigned by the SPI core.
Assign ^= SPI_CS_HIGH since we might be active high
already, and that is usually the case with GPIOs used
for chip select, even if they are in practice active low.
Add a comment clarifying why ^= SPI_CS_HIGH is the right
choice here.
Reported-by: Mark Brown <[email protected]>
Signed-off-by: Linus Walleij <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'lib/mpi/mpi-bit.c')
0 files changed, 0 insertions, 0 deletions