diff options
author | Yu Kuai <[email protected]> | 2023-03-22 11:59:26 +0800 |
---|---|---|
committer | Jens Axboe <[email protected]> | 2023-04-06 20:41:53 -0600 |
commit | 3723091ea1884d599cc8b8bf719d6f42e8d4d8b1 (patch) | |
tree | 5be8cf89940a0cc888ee2c76b50cf0f22e92c4e3 /lib/mpi/mpi-bit.c | |
parent | 5b3b9197c28c8245c3c13ddf3ddf4eb10c2b23e1 (diff) |
block: don't set GD_NEED_PART_SCAN if scan partition failed
Currently if disk_scan_partitions() failed, GD_NEED_PART_SCAN will still
set, and partition scan will be proceed again when blkdev_get_by_dev()
is called. However, this will cause a problem that re-assemble partitioned
raid device will creat partition for underlying disk.
Test procedure:
mdadm -CR /dev/md0 -l 1 -n 2 /dev/sda /dev/sdb -e 1.0
sgdisk -n 0:0:+100MiB /dev/md0
blockdev --rereadpt /dev/sda
blockdev --rereadpt /dev/sdb
mdadm -S /dev/md0
mdadm -A /dev/md0 /dev/sda /dev/sdb
Test result: underlying disk partition and raid partition can be
observed at the same time
Note that this can still happen in come corner cases that
GD_NEED_PART_SCAN can be set for underlying disk while re-assemble raid
device.
Fixes: e5cfefa97bcc ("block: fix scan partition for exclusively open device again")
Reviewed-by: Jan Kara <[email protected]>
Reviewed-by: Ming Lei <[email protected]>
Signed-off-by: Yu Kuai <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
Diffstat (limited to 'lib/mpi/mpi-bit.c')
0 files changed, 0 insertions, 0 deletions