diff options
author | Alessandro Astone <[email protected]> | 2022-04-15 14:00:14 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <[email protected]> | 2022-04-22 17:22:51 +0200 |
commit | ef38de9217a04c9077629a24652689d8fdb4c6c6 (patch) | |
tree | 238222878c25d6e32441102babbc9f60922e7842 /lib/memory-notifier-error-inject.c | |
parent | 2d1746e3fda0c3612143d7c06f8e1d1830c13e23 (diff) |
binder: Gracefully handle BINDER_TYPE_FDA objects with num_fds=0
Some android userspace is sending BINDER_TYPE_FDA objects with
num_fds=0. Like the previous patch, this is reproducible when
playing a video.
Before commit 09184ae9b575 BINDER_TYPE_FDA objects with num_fds=0
were 'correctly handled', as in no fixup was performed.
After commit 09184ae9b575 we aggregate fixup and skip regions in
binder_ptr_fixup structs and distinguish between the two by using
the skip_size field: if it's 0, then it's a fixup, otherwise skip.
When processing BINDER_TYPE_FDA objects with num_fds=0 we add a
skip region of skip_size=0, and this causes issues because now
binder_do_deferred_txn_copies will think this was a fixup region.
To address that, return early from binder_translate_fd_array to
avoid adding an empty skip region.
Fixes: 09184ae9b575 ("binder: defer copies of pre-patched txn data")
Acked-by: Todd Kjos <[email protected]>
Cc: stable <[email protected]>
Signed-off-by: Alessandro Astone <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'lib/memory-notifier-error-inject.c')
0 files changed, 0 insertions, 0 deletions