diff options
| author | Richard Fitzgerald <[email protected]> | 2024-05-08 11:08:11 +0100 |
|---|---|---|
| committer | Takashi Iwai <[email protected]> | 2024-05-08 18:18:29 +0200 |
| commit | d344873c4cbde249b7152d36a273bcc45864001e (patch) | |
| tree | c475e47422c4af696a125b0466399834569f5df5 /lib/memory-notifier-error-inject.c | |
| parent | ec6f32bc924d1c00cbcd5672510758f7088f2513 (diff) | |
ALSA: hda: cs35l56: Fix lifetime of cs_dsp instance
The cs_dsp instance is initialized in the driver probe() so it
should be freed in the driver remove(). Also fix a missing call
to cs_dsp_remove() in the error path of cs35l56_hda_common_probe().
The call to cs_dsp_remove() was being done in the component unbind
callback cs35l56_hda_unbind(). This meant that if the driver was
unbound and then re-bound it would be using an uninitialized cs_dsp
instance.
It is best to initialize the cs_dsp instance in probe() so that it
can return an error if it fails. The component binding API doesn't
have any error handling so there's no way to handle a failure if
cs_dsp was initialized in the bind.
Signed-off-by: Richard Fitzgerald <[email protected]>
Fixes: 73cfbfa9caea ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier")
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
Diffstat (limited to 'lib/memory-notifier-error-inject.c')
0 files changed, 0 insertions, 0 deletions