aboutsummaryrefslogtreecommitdiff
path: root/lib/memory-notifier-error-inject.c
diff options
context:
space:
mode:
authorMarc Zyngier <[email protected]>2023-07-13 08:06:57 +0100
committerOliver Upton <[email protected]>2023-07-13 22:23:34 +0000
commitb321c31c9b7b309dcde5e8854b741c8e6a9a05f0 (patch)
tree1af248412eccb1f5a21edc36725288753f539c09 /lib/memory-notifier-error-inject.c
parentdcf89d111199562fa5f31a1bb76f17bc4831f6da (diff)
KVM: arm64: vgic-v4: Make the doorbell request robust w.r.t preemption
Xiang reports that VMs occasionally fail to boot on GICv4.1 systems when running a preemptible kernel, as it is possible that a vCPU is blocked without requesting a doorbell interrupt. The issue is that any preemption that occurs between vgic_v4_put() and schedule() on the block path will mark the vPE as nonresident and *not* request a doorbell irq. This occurs because when the vcpu thread is resumed on its way to block, vcpu_load() will make the vPE resident again. Once the vcpu actually blocks, we don't request a doorbell anymore, and the vcpu won't be woken up on interrupt delivery. Fix it by tracking that we're entering WFI, and key the doorbell request on that flag. This allows us not to make the vPE resident when going through a preempt/schedule cycle, meaning we don't lose any state. Cc: [email protected] Fixes: 8e01d9a396e6 ("KVM: arm64: vgic-v4: Move the GICv4 residency flow to be driven by vcpu_load/put") Reported-by: Xiang Chen <[email protected]> Suggested-by: Zenghui Yu <[email protected]> Tested-by: Xiang Chen <[email protected]> Co-developed-by: Oliver Upton <[email protected]> Signed-off-by: Marc Zyngier <[email protected]> Acked-by: Zenghui Yu <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Oliver Upton <[email protected]>
Diffstat (limited to 'lib/memory-notifier-error-inject.c')
0 files changed, 0 insertions, 0 deletions