aboutsummaryrefslogtreecommitdiff
path: root/lib/memory-notifier-error-inject.c
diff options
context:
space:
mode:
authorJiri Bohac <[email protected]>2014-04-18 17:23:11 +0200
committerThomas Gleixner <[email protected]>2014-04-30 13:46:17 +0200
commit98a01e779f3c66b0b11cd7e64d531c0e41c95762 (patch)
tree318f0b56031e4ee8789002f465ccaa30ffedc249 /lib/memory-notifier-error-inject.c
parent012a45e3f4af68e86d85cce060c6c2fed56498b2 (diff)
timer: Prevent overflow in apply_slack
On architectures with sizeof(int) < sizeof (long), the computation of mask inside apply_slack() can be undefined if the computed bit is > 32. E.g. with: expires = 0xffffe6f5 and slack = 25, we get: expires_limit = 0x20000000e bit = 33 mask = (1 << 33) - 1 /* undefined */ On x86, mask becomes 1 and and the slack is not applied properly. On s390, mask is -1, expires is set to 0 and the timer fires immediately. Use 1UL << bit to solve that issue. Suggested-by: Deborah Townsend <[email protected]> Signed-off-by: Jiri Bohac <[email protected]> Cc: [email protected] Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Thomas Gleixner <[email protected]>
Diffstat (limited to 'lib/memory-notifier-error-inject.c')
0 files changed, 0 insertions, 0 deletions