diff options
author | Mateusz Guzik <[email protected]> | 2024-08-10 08:47:53 +0200 |
---|---|---|
committer | Christian Brauner <[email protected]> | 2024-08-30 08:22:36 +0200 |
commit | 8447d848e1dc6d42d1dcd00f133d7715fc732c47 (patch) | |
tree | ce84df5664c493a20b444ab48b694d076a1d61fc /lib/memory-notifier-error-inject.c | |
parent | 193b72792fdba54aa2af6c3ad72ce16c3f06b4f7 (diff) |
vfs: only read fops once in fops_get/put
In do_dentry_open() the usage is:
f->f_op = fops_get(inode->i_fop);
In generated asm the compiler emits 2 reads from inode->i_fop instead of
just one.
This popped up due to false-sharing where loads from that offset end up
bouncing a cacheline during parallel open. While this is going to be fixed,
the spurious load does not need to be there.
This makes do_dentry_open() go down from 1177 to 1154 bytes.
fops_put() is patched to maintain some consistency.
No functional changes.
Reviewed-by: Josef Bacik <[email protected]>
Signed-off-by: Mateusz Guzik <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Christian Brauner <[email protected]>
Diffstat (limited to 'lib/memory-notifier-error-inject.c')
0 files changed, 0 insertions, 0 deletions