diff options
| author | Konstantin Khlebnikov <[email protected]> | 2015-02-09 16:42:49 +0300 |
|---|---|---|
| committer | Jens Axboe <[email protected]> | 2015-02-09 10:22:39 -0700 |
| commit | 69abaffec7d47a083739b79e3066cb3730eba72e (patch) | |
| tree | e217ce01355ab8b2ca1d58c54c983fda70e026f2 /lib/memory-notifier-error-inject.c | |
| parent | 9f9ee1f2b2f94f19437ae2def7c0d6636d7fe02e (diff) | |
cfq-iosched: handle failure of cfq group allocation
Cfq_lookup_create_cfqg() allocates struct blkcg_gq using GFP_ATOMIC.
In cfq_find_alloc_queue() possible allocation failure is not handled.
As a result kernel oopses on NULL pointer dereference when
cfq_link_cfqq_cfqg() calls cfqg_get() for NULL pointer.
Bug was introduced in v3.5 in commit cd1604fab4f9 ("blkcg: factor
out blkio_group creation"). Prior to that commit cfq group lookup
had returned pointer to root group as fallback.
This patch handles this error using existing fallback oom_cfqq.
Signed-off-by: Konstantin Khlebnikov <[email protected]>
Acked-by: Tejun Heo <[email protected]>
Acked-by: Vivek Goyal <[email protected]>
Fixes: cd1604fab4f9 ("blkcg: factor out blkio_group creation")
Cc: [email protected]
Signed-off-by: Jens Axboe <[email protected]>
Diffstat (limited to 'lib/memory-notifier-error-inject.c')
0 files changed, 0 insertions, 0 deletions