diff options
author | Janusz Krzysztofik <[email protected]> | 2022-11-21 15:56:55 +0100 |
---|---|---|
committer | Rodrigo Vivi <[email protected]> | 2022-11-29 12:30:10 -0500 |
commit | 35aba5f51a39fb95351844ffb14ec02b8970e19f (patch) | |
tree | ee115c52181a9811f398774f9f4169335b1bc31d /lib/memory-notifier-error-inject.c | |
parent | 6a5347293992e0412bc748dae11228a7081393fa (diff) |
drm/i915: Never return 0 if not all requests retired
Users of intel_gt_retire_requests_timeout() expect 0 return value on
success. However, we have no protection from passing back 0 potentially
returned by a call to dma_fence_wait_timeout() when it succedes right
after its timeout has expired.
Replace 0 with -ETIME before potentially using the timeout value as return
code, so -ETIME is returned if there are still some requests not retired
after timeout, 0 otherwise.
v3: Use conditional expression, more compact but also better reflecting
intention standing behind the change.
v2: Move the added lines down so flush_submission() is not affected.
Fixes: f33a8a51602c ("drm/i915: Merge wait_for_timelines with retire_request")
Signed-off-by: Janusz Krzysztofik <[email protected]>
Reviewed-by: Andrzej Hajda <[email protected]>
Cc: [email protected] # v5.5+
Signed-off-by: Tvrtko Ursulin <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
(cherry picked from commit f301a29f143760ce8d3d6b6a8436d45d3448cde6)
Signed-off-by: Rodrigo Vivi <[email protected]>
Diffstat (limited to 'lib/memory-notifier-error-inject.c')
0 files changed, 0 insertions, 0 deletions