aboutsummaryrefslogtreecommitdiff
path: root/lib/memory-notifier-error-inject.c
diff options
context:
space:
mode:
authorCatalin Marinas <[email protected]>2019-10-04 14:46:24 +0100
committerLinus Torvalds <[email protected]>2019-10-14 08:56:16 -0700
commit2abd839aa7e615f2bbc50c8ba7deb9e40d186768 (patch)
tree1e72fe29e969967bfdbf547edc1f98ff8a1002fd /lib/memory-notifier-error-inject.c
parent4f5cafb5cb8471e54afdc9054d973535614f7675 (diff)
kmemleak: Do not corrupt the object_list during clean-up
In case of an error (e.g. memory pool too small), kmemleak disables itself and cleans up the already allocated metadata objects. However, if this happens early before the RCU callback mechanism is available, put_object() skips call_rcu() and frees the object directly. This is not safe with the RCU list traversal in __kmemleak_do_cleanup(). Change the list traversal in __kmemleak_do_cleanup() to list_for_each_entry_safe() and remove the rcu_read_{lock,unlock} since the kmemleak is already disabled at this point. In addition, avoid an unnecessary metadata object rb-tree look-up since it already has the struct kmemleak_object pointer. Fixes: c5665868183f ("mm: kmemleak: use the memory pool for early allocations") Reported-by: Alexey Kardashevskiy <[email protected]> Reported-by: Marc Dionne <[email protected]> Reported-by: Ted Ts'o <[email protected]> Cc: Andrew Morton <[email protected]> Signed-off-by: Catalin Marinas <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'lib/memory-notifier-error-inject.c')
0 files changed, 0 insertions, 0 deletions