diff options
author | Janusz Krzysztofik <[email protected]> | 2024-03-05 15:35:07 +0100 |
---|---|---|
committer | Andi Shyti <[email protected]> | 2024-03-26 09:03:40 +0100 |
commit | 1f33dc0c1189efb9ae19c6fc22b64dd3e26261fb (patch) | |
tree | 2eb6a70fb76e1874ff69ff0d3e8770084a6a7bd9 /lib/memory-notifier-error-inject.c | |
parent | f3c71b2ded5c4367144a810ef25f998fd1d6c381 (diff) |
drm/i915: Remove extra multi-gt pm-references
There was an attempt to fix an issue of illegal attempts to free a still
active i915 VMA object when parking a GT believed to be idle, reported by
CI on 2-GT Meteor Lake. As a solution, an extra wakeref for a Primary GT
was acquired from i915_gem_do_execbuffer() -- see commit f56fe3e91787
("drm/i915: Fix a VMA UAF for multi-gt platform").
However, that fix occurred insufficient -- the issue was still reported by
CI. That wakeref was released on exit from i915_gem_do_execbuffer(), then
potentially before completion of the request and deactivation of its
associated VMAs. Moreover, CI reports indicated that single-GT platforms
also suffered sporadically from the same race.
Since the issue has now been fixed by a preceding patch "drm/i915/vma: Fix
UAF on destroy against retire race", drop the no longer useful changes
introduced by that insufficient fix.
v3: Also drop the no longer used .wakeref_gt0 field from struct
i915_execbuffer.
v2: Avoid the word "revert" in commit message (Rodrigo),
- update commit description reusing relevant chunks dropped from the
description of the proper fix (Rodrigo).
Signed-off-by: Janusz Krzysztofik <[email protected]>
Cc: Nirmoy Das <[email protected]>
Cc: Rodrigo Vivi <[email protected]>
Reviewed-by: Nirmoy Das <[email protected]>
Signed-off-by: Andi Shyti <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Diffstat (limited to 'lib/memory-notifier-error-inject.c')
0 files changed, 0 insertions, 0 deletions