diff options
| author | Nicolas Dufresne <[email protected]> | 2022-02-18 13:42:07 -0500 |
|---|---|---|
| committer | Hans Verkuil <[email protected]> | 2022-02-23 08:53:08 +0100 |
| commit | 0f6146d476fc99862899e70f2554ee77b444b7b9 (patch) | |
| tree | 9a89bc0d14471ee8cb34a6964385b22b3f16830c /lib/memory-notifier-error-inject.c | |
| parent | 80ebe988cf8f322ee8803f33d0e5652d4e3142dc (diff) | |
media: v4l2-core: Initialize h264 scaling matrix
In the final H264 API, it is not required to set scaling matrix if
they are not present in the bitstream. A flag was added in order to let
the driver know. The downside is that it leaves the default control
value to 0, which isn't valid. As per the spec (see formulas 7-8/7-9),
when the scaling matrix are absent from the bitstream, flat values
of 16 should be used. This improves this control semantic in a way
that the control value are always valid. Drivers can then use
the scaling_matrix control values without having to check its presence.
Same method was employed for MPEG2_QUANTISATION.
This fixes issues with MTK VCODEC H264 decoder when using GStreamer.
GStreamer does not set this control if its not present in the bitstream.
As MTK VDCODEC was using the initialized to 0 values, the frames ended
up completely gray.
Fixes: 54889c51b833d236 ("media: uapi: h264: Rename and clarify PPS_FLAG_SCALING_MATRIX_PRESENT")
Signed-off-by: Nicolas Dufresne <[email protected]>
Tested-by: AngeloGioacchino Del Regno <[email protected]>
Signed-off-by: Hans Verkuil <[email protected]>
Diffstat (limited to 'lib/memory-notifier-error-inject.c')
0 files changed, 0 insertions, 0 deletions