diff options
| author | Ewan D. Milne <[email protected]> | 2012-11-02 09:38:34 -0400 |
|---|---|---|
| committer | James Bottomley <[email protected]> | 2013-07-23 07:41:53 -0700 |
| commit | 085b513f97d8d799d28491239be4b451bcd8c2c5 (patch) | |
| tree | 1f7e0786f3e7ccf24cc8f77077540ebf7285fbd7 /lib/memory-notifier-error-inject.c | |
| parent | c3ccb1d7cf4c4549151876dd37c0944a682fd9e1 (diff) | |
[SCSI] sd: fix crash when UA received on DIF enabled device
sd_prep_fn will allocate a larger CDB for the command via mempool_alloc
for devices using DIF type 2 protection. This CDB was being freed
in sd_done, which results in a kernel crash if the command is retried
due to a UNIT ATTENTION. This change moves the code to free the larger
CDB into sd_unprep_fn instead, which is invoked after the request is
complete.
It is no longer necessary to call scsi_print_command separately for
this case as the ->cmnd will no longer be NULL in the normal code path.
Also removed conditional test for DIF type 2 when freeing the larger
CDB because the protection_type could have been changed via sysfs while
the command was executing.
Signed-off-by: Ewan D. Milne <[email protected]>
Acked-by: Martin K. Petersen <[email protected]>
Cc: <[email protected]>
Signed-off-by: James Bottomley <[email protected]>
Diffstat (limited to 'lib/memory-notifier-error-inject.c')
0 files changed, 0 insertions, 0 deletions