diff options
author | Ville Syrjälä <ville.syrjala@linux.intel.com> | 2020-02-28 22:35:49 +0200 |
---|---|---|
committer | Ville Syrjälä <ville.syrjala@linux.intel.com> | 2020-03-05 15:53:33 +0200 |
commit | e7f54e6c198159ff593f1d52707d40a82899cfc7 (patch) | |
tree | 9de1552b730f41318ac1be8f562a5f78c95695ea /lib/math/cordic.c | |
parent | 9b11bbf0c4008fa0b715ed68db0d5669175413c5 (diff) |
drm/i915: Don't check uv_wm in skl_plane_wm_equals()
The hardware never sees the uv_wm values (apart from
uv_wm.min_ddb_alloc affecting the ddb allocation). Thus there
is no point in comparing uv_wm to determine if we need to
reprogram the watermark registers. So let's check only the
rgb/y watermark in skl_plane_wm_equals(). But let's leave
a comment behind so that the next person reading this doesn't
get as confused as I did when I added this check.
If the ddb allocation ends up changing due to uv_wm
skl_ddb_add_affected_planes() takes care of adding the plane
to the state.
TODO: we should perhaps just eliminate uv_wm from the state
and simply track the min_ddb_alloc for uv instead.
Cc: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200228203552.30273-1-ville.syrjala@linux.intel.com
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Diffstat (limited to 'lib/math/cordic.c')
0 files changed, 0 insertions, 0 deletions