aboutsummaryrefslogtreecommitdiff
path: root/lib/livepatch/test_klp_atomic_replace.c
diff options
context:
space:
mode:
authorJohn Hubbard <[email protected]>2020-08-06 23:19:51 -0700
committerLinus Torvalds <[email protected]>2020-08-07 11:33:23 -0700
commit6dc5ea16c86f753951f53085aa04df49cf17cb50 (patch)
tree46419bf658f6133fec008c00f845e79a4f2e47b7 /lib/livepatch/test_klp_atomic_replace.c
parent54a75157d97976f35e63e37e31e39bda622cbf39 (diff)
mm, dump_page: do not crash with bad compound_mapcount()
If a compound page is being split while dump_page() is being run on that page, we can end up calling compound_mapcount() on a page that is no longer compound. This leads to a crash (already seen at least once in the field), due to the VM_BUG_ON_PAGE() assertion inside compound_mapcount(). (The above is from Matthew Wilcox's analysis of Qian Cai's bug report.) A similar problem is possible, via compound_pincount() instead of compound_mapcount(). In order to avoid this kind of crash, make dump_page() slightly more robust, by providing a pair of simpler routines that don't contain assertions: head_mapcount() and head_pincount(). For debug tools, we don't want to go *too* far in this direction, but this is a simple small fix, and the crash has already been seen, so it's a good trade-off. Reported-by: Qian Cai <[email protected]> Suggested-by: Matthew Wilcox <[email protected]> Signed-off-by: John Hubbard <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Acked-by: Vlastimil Babka <[email protected]> Cc: Kirill A. Shutemov <[email protected]> Cc: Mike Rapoport <[email protected]> Cc: William Kucharski <[email protected]> Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'lib/livepatch/test_klp_atomic_replace.c')
0 files changed, 0 insertions, 0 deletions