diff options
author | Michael Zhivich <[email protected]> | 2019-04-08 10:48:46 -0400 |
---|---|---|
committer | David S. Miller <[email protected]> | 2019-04-08 16:30:43 -0700 |
commit | caf2c5205d82ff0d758096a69a7e0466c38d4dbb (patch) | |
tree | 3637c18af6bfa796964d45c512bcd87ec14606ee /lib/kobject.c | |
parent | afe64245af9f58267e7fa8fb76ad5650ee7ec25f (diff) |
broadcom: tg3: fix use of SPEED_UNKNOWN ethtool constant
tg3 driver uses u16 to store SPEED_UKNOWN ethtool constant,
which is defined as -1, resulting in value truncation and
thus incorrect test results against SPEED_UNKNOWN.
For example, the following test will print "False":
u16 speed = SPEED_UNKNOWN;
if (speed == SPEED_UNKNOWN)
printf("True");
else
printf("False");
Change storage of speed to use u32 to avoid this issue.
Signed-off-by: Michael Zhivich <[email protected]>
Reviewed-by: Andrew Lunn <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'lib/kobject.c')
0 files changed, 0 insertions, 0 deletions