diff options
| author | Kai Vehmanen <kai.vehmanen@linux.intel.com> | 2024-07-04 10:57:08 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2024-07-04 12:09:09 +0100 |
| commit | 9065693dcc13f287b9e4991f43aee70cf5538fdd (patch) | |
| tree | 7110d0dc1ecfcf936e76690282c3d964acc18d9b /lib/error-inject.c | |
| parent | 2163aff6bebbb752edf73f79700f5e2095f3559e (diff) | |
ASoC: SOF: Intel: hda: fix null deref on system suspend entry
When system enters suspend with an active stream, SOF core
calls hw_params_upon_resume(). On Intel platforms with HDA DMA used
to manage the link DMA, this leads to call chain of
hda_dsp_set_hw_params_upon_resume()
-> hda_dsp_dais_suspend()
-> hda_dai_suspend()
-> hda_ipc4_post_trigger()
A bug is hit in hda_dai_suspend() as hda_link_dma_cleanup() is run first,
which clears hext_stream->link_substream, and then hda_ipc4_post_trigger()
is called with a NULL snd_pcm_substream pointer.
Fixes: 2b009fa0823c ("ASoC: SOF: Intel: hda: Unify DAI drv ops for IPC3 and IPC4")
Link: https://github.com/thesofproject/linux/issues/5080
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240704085708.371414-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'lib/error-inject.c')
0 files changed, 0 insertions, 0 deletions