aboutsummaryrefslogtreecommitdiff
path: root/lib/dynamic_debug.c
diff options
context:
space:
mode:
authorWen Yang <[email protected]>2019-01-03 01:09:53 +0800
committerDavid S. Miller <[email protected]>2019-01-04 12:50:43 -0800
commit8d68100ab4ad92560a16a68b72e068613ac4d573 (patch)
tree136f714932c2a9ff615fcf16745a4072b402402a /lib/dynamic_debug.c
parent36352991835ce99e46b4441dd0eb6980f9a83e8f (diff)
soc/fsl/qe: fix err handling of ucc_of_parse_tdm
Currently there are some issues with the ucc_of_parse_tdm function: 1, a possible null pointer dereference in ucc_of_parse_tdm, detected by the semantic patch deref_null.cocci, with the following warning: drivers/soc/fsl/qe/qe_tdm.c:177:21-24: ERROR: pdev is NULL but dereferenced. 2, dev gets modified, so in any case that devm_iounmap() will fail even when the new pdev is valid, because the iomap was done with a different pdev. 3, there is no driver bind with the "fsl,t1040-qe-si" or "fsl,t1040-qe-siram" device. So allocating resources using devm_*() with these devices won't provide a cleanup path for these resources when the caller fails. This patch fixes them. Suggested-by: Li Yang <[email protected]> Suggested-by: Christophe LEROY <[email protected]> Signed-off-by: Wen Yang <[email protected]> Reviewed-by: Peng Hao <[email protected]> CC: Julia Lawall <[email protected]> CC: Zhao Qiang <[email protected]> CC: David S. Miller <[email protected]> CC: [email protected] CC: [email protected] CC: [email protected] Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'lib/dynamic_debug.c')
0 files changed, 0 insertions, 0 deletions