diff options
| author | Eric Dumazet <[email protected]> | 2019-12-12 12:55:29 -0800 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2019-12-13 21:58:40 -0800 |
| commit | 1f85e6267caca44b30c54711652b0726fadbb131 (patch) | |
| tree | fe2c93adefc0440f91f6edd059f74895da12baa4 /lib/debugobjects.c | |
| parent | 5c9934b6767b16ba60be22ec3cbd4379ad64170d (diff) | |
tcp: do not send empty skb from tcp_write_xmit()
Backport of commit fdfc5c8594c2 ("tcp: remove empty skb from
write queue in error cases") in linux-4.14 stable triggered
various bugs. One of them has been fixed in commit ba2ddb43f270
("tcp: Don't dequeue SYN/FIN-segments from write-queue"), but
we still have crashes in some occasions.
Root-cause is that when tcp_sendmsg() has allocated a fresh
skb and could not append a fragment before being blocked
in sk_stream_wait_memory(), tcp_write_xmit() might be called
and decide to send this fresh and empty skb.
Sending an empty packet is not only silly, it might have caused
many issues we had in the past with tp->packets_out being
out of sync.
Fixes: c65f7f00c587 ("[TCP]: Simplify SKB data portion allocation with NETIF_F_SG.")
Signed-off-by: Eric Dumazet <[email protected]>
Cc: Christoph Paasch <[email protected]>
Acked-by: Neal Cardwell <[email protected]>
Cc: Jason Baron <[email protected]>
Acked-by: Soheil Hassas Yeganeh <[email protected]>
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'lib/debugobjects.c')
0 files changed, 0 insertions, 0 deletions