diff options
author | Christoph Paasch <[email protected]> | 2024-03-06 10:11:17 -0800 |
---|---|---|
committer | Jakub Kicinski <[email protected]> | 2024-03-07 20:42:13 -0800 |
commit | 8edbd3960150ee7dd7a2857bd9a5cf14906facc2 (patch) | |
tree | 85d480f4f73234cf604802a01de1a3df8664b031 /lib/crypto/mpi/mpiutil.c | |
parent | 4f6473ad60947c88c9eac21fe16233e795d3a2f3 (diff) |
mpls: Do not orphan the skb
We observed that TCP-pacing was falling back to the TCP-layer pacing
instead of utilizing sch_fq for the pacing. This causes significant
CPU-usage due to the hrtimer running on a per-TCP-connection basis.
The issue is that mpls_xmit() calls skb_orphan() and thus sets
skb->sk to NULL. Which implies that many of the goodies of TCP won't
work. Pacing falls back to TCP-layer pacing. TCP Small Queues does not
work, ...
It is safe to remove this call to skb_orphan() in mpls_xmit() as there
really is not reason for it to be there. It appears that this call to
skb_orphan comes from the very initial implementation of MPLS.
Cc: Roopa Prabhu <[email protected]>
Reported-by: Craig Taylor <[email protected]>
Signed-off-by: Christoph Paasch <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'lib/crypto/mpi/mpiutil.c')
0 files changed, 0 insertions, 0 deletions