diff options
author | Ramachandra K <[email protected]> | 2009-02-27 10:33:12 -0800 |
---|---|---|
committer | Roland Dreier <[email protected]> | 2009-02-27 10:33:12 -0800 |
commit | 7020cb0fe216fdcec246cdc2412614a3190fbb2f (patch) | |
tree | 73fefbde0a05e9598b0ff871eca631aeea495e61 /lib/cpu-notifier-error-inject.c | |
parent | f3b8436ad9a8ad36b3c9fa1fe030c7f38e5d3d0b (diff) |
IB/mad: Fix RMPP header RRespTime manipulation
Fix ib_set_rmpp_flags() to use the correct bit mask for RRespTime. In
the 8-bit field of the RMPP header, the first 5 bits are RRespTime and
next 3 bits are RMPPFlags. Hence to retain the first 5 bits, the mask
should be 0xF8 instead of 0xF1.
ack_recv()-->format_ack() calls ib_set_rmpp_flags() and due to the
incorrect ANDing with 0xF1, RRespTime got changed incorrectly and RMPP
Acks sent back always had a RRespTime of 0x1E (30) which caused the
other end to consider the time outs to be approximately 4297 seconds
(i.e. in the order of 4*2^30) instead of the usual ~4 seconds (order
of 4*2^20).
Signed-off-by: Ramachandra K <[email protected]>
Acked-by: Sean Hefty <[email protected]>
Signed-off-by: Roland Dreier <[email protected]>
Diffstat (limited to 'lib/cpu-notifier-error-inject.c')
0 files changed, 0 insertions, 0 deletions