aboutsummaryrefslogtreecommitdiff
path: root/lib/bug.c
diff options
context:
space:
mode:
authorAdam Jackson <ajax@redhat.com>2010-05-27 17:26:45 -0400
committerEric Anholt <eric@anholt.net>2010-06-04 17:21:41 -0700
commitc496fa1fff0248ef8cd637efb52b70dea7afaa9d (patch)
treebbdc1b56f61f12d68509a2f927a9c777dc35eee7 /lib/bug.c
parentf458823b864c6def488f951a79986fa205aba4f1 (diff)
drm/i915/gen4: Fix interrupt setup ordering
Unmask, then enable interrupts, then enable interrupt sources; matches PCH ordering. The old way (sources, enable, unmask) gives a window during which interrupt conditions would appear in ISR but would never reach IIR and thus never raise an IRQ. Since interrupts only trigger on rising edges in ISR, this would lead to conditions where (for example) output hotplugging would never fire an interrupt because it was already stuck on in ISR. Also, since we know IIR and PIPExSTAT have been cleared during irq_preinstall, don't clear them again during irq_postinstall, nothing good can come of that. Signed-off-by: Adam Jackson <ajax@redhat.com> Signed-off-by: Eric Anholt <eric@anholt.net>
Diffstat (limited to 'lib/bug.c')
0 files changed, 0 insertions, 0 deletions