aboutsummaryrefslogtreecommitdiff
path: root/kernel
diff options
context:
space:
mode:
authorXiaoming Ni <[email protected]>2019-12-04 16:50:43 -0800
committerLinus Torvalds <[email protected]>2019-12-04 19:44:12 -0800
commit5adaabb65a267d890b29193af2dbc38a3b85bbf2 (patch)
treebe4d81fc2a55714a844decfebd97e3afdd902e3e /kernel
parent1a50cb80f219c44adb6265f5071b81fc3c1deced (diff)
kernel/notifier.c: remove notifier_chain_cond_register()
The only difference between notifier_chain_cond_register() and notifier_chain_register() is the lack of warning hints for duplicate registrations. Use notifier_chain_register() instead of notifier_chain_cond_register() to avoid duplicate code Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Xiaoming Ni <[email protected]> Reviewed-by: Andrew Morton <[email protected]> Cc: Alan Stern <[email protected]> Cc: Alexey Dobriyan <[email protected]> Cc: Andy Lutomirski <[email protected]> Cc: Anna Schumaker <[email protected]> Cc: Arjan van de Ven <[email protected]> Cc: Chuck Lever <[email protected]> Cc: David S. Miller <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: J. Bruce Fields <[email protected]> Cc: Jeff Layton <[email protected]> Cc: Nadia Derbey <[email protected]> Cc: "Paul E. McKenney" <[email protected]> Cc: Sam Protsenko <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: Trond Myklebust <[email protected]> Cc: Vasily Averin <[email protected]> Cc: Viresh Kumar <[email protected]> Cc: YueHaibing <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'kernel')
-rw-r--r--kernel/notifier.c17
1 files changed, 1 insertions, 16 deletions
diff --git a/kernel/notifier.c b/kernel/notifier.c
index 30bedb8be6dd..e3d221f092fe 100644
--- a/kernel/notifier.c
+++ b/kernel/notifier.c
@@ -36,21 +36,6 @@ static int notifier_chain_register(struct notifier_block **nl,
return 0;
}
-static int notifier_chain_cond_register(struct notifier_block **nl,
- struct notifier_block *n)
-{
- while ((*nl) != NULL) {
- if ((*nl) == n)
- return 0;
- if (n->priority > (*nl)->priority)
- break;
- nl = &((*nl)->next);
- }
- n->next = *nl;
- rcu_assign_pointer(*nl, n);
- return 0;
-}
-
static int notifier_chain_unregister(struct notifier_block **nl,
struct notifier_block *n)
{
@@ -252,7 +237,7 @@ int blocking_notifier_chain_cond_register(struct blocking_notifier_head *nh,
int ret;
down_write(&nh->rwsem);
- ret = notifier_chain_cond_register(&nh->head, n);
+ ret = notifier_chain_register(&nh->head, n);
up_write(&nh->rwsem);
return ret;
}