diff options
| author | Vladimir Oltean <[email protected]> | 2021-01-09 02:01:52 +0200 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2021-01-11 16:00:57 -0800 |
| commit | a52b2da778fc93e01c4e5a744953f2ba1ec01c00 (patch) | |
| tree | ceee4f81ffda53657b8e10aa23a8248fa416ef0f /include | |
| parent | 77b61365ecefb2404326c924e215f1ed5a680285 (diff) | |
net: dsa: remove the transactional logic from MDB entries
For many drivers, the .port_mdb_prepare callback was not a good opportunity
to avoid any error condition, and they would suppress errors found during
the actual commit phase.
Where a logical separation between the prepare and the commit phase
existed, the function that used to implement the .port_mdb_prepare
callback still exists, but now it is called directly from .port_mdb_add,
which was modified to return an int code.
Signed-off-by: Vladimir Oltean <[email protected]>
Reviewed-by: Florian Fainelli <[email protected]>
Acked-by: Linus Walleij <[email protected]>
Acked-by: Jiri Pirko <[email protected]>
Reviewed-by: Kurt Kanzenbach <[email protected]> # hellcreek
Reviewed-by: Linus Wallei <[email protected]> # RTL8366
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'include')
| -rw-r--r-- | include/net/dsa.h | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/include/net/dsa.h b/include/net/dsa.h index d0f043091969..b8c0550dfa74 100644 --- a/include/net/dsa.h +++ b/include/net/dsa.h @@ -585,10 +585,8 @@ struct dsa_switch_ops { /* * Multicast database */ - int (*port_mdb_prepare)(struct dsa_switch *ds, int port, + int (*port_mdb_add)(struct dsa_switch *ds, int port, const struct switchdev_obj_port_mdb *mdb); - void (*port_mdb_add)(struct dsa_switch *ds, int port, - const struct switchdev_obj_port_mdb *mdb); int (*port_mdb_del)(struct dsa_switch *ds, int port, const struct switchdev_obj_port_mdb *mdb); /* |