diff options
| author | Dust Li <[email protected]> | 2019-11-28 14:29:09 +0800 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2019-11-30 10:38:40 -0800 |
| commit | 14e54ab9143fa60794d13ea0a66c792a2046a8f3 (patch) | |
| tree | 225370a19f639a570d6213833c6a5fb492928977 /include | |
| parent | 395eba7d0c122c650fb8b6ae8c6815cbfdc39ca9 (diff) | |
net: sched: fix `tc -s class show` no bstats on class with nolock subqueues
When a classful qdisc's child qdisc has set the flag
TCQ_F_CPUSTATS (pfifo_fast for example), the child qdisc's
cpu_bstats should be passed to gnet_stats_copy_basic(),
but many classful qdisc didn't do that. As a result,
`tc -s class show dev DEV` always return 0 for bytes and
packets in this case.
Pass the child qdisc's cpu_bstats to gnet_stats_copy_basic()
to fix this issue.
The qstats also has this problem, but it has been fixed
in 5dd431b6b9 ("net: sched: introduce and use qstats read...")
and bstats still remains buggy.
Fixes: 22e0f8b9322c ("net: sched: make bstats per cpu and estimator RCU safe")
Signed-off-by: Dust Li <[email protected]>
Signed-off-by: Tony Lu <[email protected]>
Acked-by: Cong Wang <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions