diff options
| author | Waiman Long <[email protected]> | 2023-06-06 14:07:24 -0400 |
|---|---|---|
| committer | Jens Axboe <[email protected]> | 2023-06-07 07:51:34 -0600 |
| commit | 3d2af77e31ade05ff7ccc3658c3635ec1bea0979 (patch) | |
| tree | 719e78adff52ac9922e337e5c5bc7fbe169ca639 /include/uapi/linux | |
| parent | a7cfa0af0c88353b4eb59db5a2a0fbe35329b3f9 (diff) | |
blk-cgroup: Reinit blkg_iostat_set after clearing in blkcg_reset_stats()
When blkg_alloc() is called to allocate a blkcg_gq structure
with the associated blkg_iostat_set's, there are 2 fields within
blkg_iostat_set that requires proper initialization - blkg & sync.
The former field was introduced by commit 3b8cc6298724 ("blk-cgroup:
Optimize blkcg_rstat_flush()") while the later one was introduced by
commit f73316482977 ("blk-cgroup: reimplement basic IO stats using
cgroup rstat").
Unfortunately those fields in the blkg_iostat_set's are not properly
re-initialized when they are cleared in v1's blkcg_reset_stats(). This
can lead to a kernel panic due to NULL pointer access of the blkg
pointer. The missing initialization of sync is less problematic and
can be a problem in a debug kernel due to missing lockdep initialization.
Fix these problems by re-initializing them after memory clearing.
Fixes: 3b8cc6298724 ("blk-cgroup: Optimize blkcg_rstat_flush()")
Fixes: f73316482977 ("blk-cgroup: reimplement basic IO stats using cgroup rstat")
Signed-off-by: Waiman Long <[email protected]>
Reviewed-by: Ming Lei <[email protected]>
Acked-by: Tejun Heo <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jens Axboe <[email protected]>
Diffstat (limited to 'include/uapi/linux')
0 files changed, 0 insertions, 0 deletions