diff options
| author | Ilpo Järvinen <[email protected]> | 2022-06-08 12:54:29 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2022-06-10 13:45:09 +0200 |
| commit | 7a3525e48cf7c1d85c38cedb452912cb99b60c43 (patch) | |
| tree | c78fb3fdce68704e2240faec134bd91527b70a0e /include/linux | |
| parent | 6a4241e8f9b17aa17f55842d6478f280c22d2b44 (diff) | |
serial: 8250: Adjust misleading LSR related comment
serial8250_rx_chars() has max_count based character limit. If it
triggers, the function returns the old LSR value (and it has never
returned only flags which were not handled). Adjust the comment to
match behavior and warn about which flags can be depended on.
I'd have moved LSR read before LSR read and used serial_lsr_in() also
here but I came across an old discussion about the topic. That
discussion generated commit d22f8f10683c ("serial: 8250: Fix lost rx
state") so I left the code as it is (it works as long as the callers
only use a subset of the LSR flags which holds true today) and changed
the comment instead.
Link: https://www.spinics.net/lists/linux-serial/msg16220.html
Reviewed-by: Andy Shevchenko <[email protected]>
Signed-off-by: Ilpo Järvinen <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'include/linux')
0 files changed, 0 insertions, 0 deletions