aboutsummaryrefslogtreecommitdiff
path: root/include/linux/loop.h
diff options
context:
space:
mode:
authorPaul Jackson <[email protected]>2007-10-18 23:39:28 -0700
committerLinus Torvalds <[email protected]>2007-10-19 11:53:35 -0700
commit55a230aae650157720becc09cadb7d10efbf5013 (patch)
treea4d85dd865c4e939580fdde986a0d29912e45a7e /include/linux/loop.h
parent8f731f7d83d6c6a3eeb32cce79bfcddbf7fac8cc (diff)
cpuset: zero malloc - revert the old cpuset fix
The cpuset code to present a list of tasks using a cpuset to user space could write to an array that it had kmalloc'd, after a kmalloc request of zero size. The problem was that the code didn't check for writes past the allocated end of the array until -after- the first write. This is a race condition that is likely rare -- it would only show up if a cpuset went from being empty to having a task in it, during the brief time between the allocation and the first write. Prior to roughly 2.6.22 kernels, this was also a benign problem, because a zero kmalloc returned a few usable bytes anyway, and no harm was done with the bogus write. With the 2.6.22 kernel changes to make issue a warning if code tries to write to the location returned from a zero size allocation, this problem is no longer benign. This cpuset code would occassionally trigger that warning. The fix is trivial -- check before storing into the array, not after, whether the array is big enough to hold the store. Cc: "Eric W. Biederman" <[email protected]> Cc: "Serge E. Hallyn" <[email protected]> Cc: Balbir Singh <[email protected]> Cc: Dave Hansen <[email protected]> Cc: Herbert Poetzl <[email protected]> Cc: Kirill Korotaev <[email protected]> Cc: Paul Menage <[email protected]> Cc: Srivatsa Vaddagiri <[email protected]> Cc: Christoph Lameter <[email protected]> Signed-off-by: Paul Jackson <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'include/linux/loop.h')
0 files changed, 0 insertions, 0 deletions