diff options
| author | Eric Dumazet <[email protected]> | 2017-11-02 12:30:25 -0700 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2017-11-03 14:29:01 +0900 |
| commit | 3b11775033dc87c3d161996c54507b15ba26414a (patch) | |
| tree | 01e52ff98514d77a36116f02f3745b1bce20d519 /include/linux/fpga/fpga-bridge.h | |
| parent | 25dd169aea6553aea548197a5d4580bbdeda1c85 (diff) | |
tcp: do not mangle skb->cb[] in tcp_make_synack()
Christoph Paasch sent a patch to address the following issue :
tcp_make_synack() is leaving some TCP private info in skb->cb[],
then send the packet by other means than tcp_transmit_skb()
tcp_transmit_skb() makes sure to clear skb->cb[] to not confuse
IPv4/IPV6 stacks, but we have no such cleanup for SYNACK.
tcp_make_synack() should not use tcp_init_nondata_skb() :
tcp_init_nondata_skb() really should be limited to skbs put in write/rtx
queues (the ones that are only sent via tcp_transmit_skb())
This patch fixes the issue and should even save few cpu cycles ;)
Fixes: 971f10eca186 ("tcp: better TCP_SKB_CB layout to reduce cache line misses")
Signed-off-by: Eric Dumazet <[email protected]>
Reported-by: Christoph Paasch <[email protected]>
Reviewed-by: Christoph Paasch <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'include/linux/fpga/fpga-bridge.h')
0 files changed, 0 insertions, 0 deletions