diff options
| author | Christian Brauner <brauner@kernel.org> | 2024-08-30 15:04:59 +0200 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2024-09-12 11:58:45 +0200 |
| commit | 5e9b50dea970ae6d3e1309d4254157099734a2af (patch) | |
| tree | 89f9d1704d813436a4125ebc615a4dd0278578a6 /fs | |
| parent | 1146e5a69efca76501378f748388fd7742ad09cf (diff) | |
fs: add f_pipe
Only regular files with FMODE_ATOMIC_POS and directories need
f_pos_lock. Place a new f_pipe member in a union with f_pos_lock
that they can use and make them stop abusing f_version in follow-up
patches.
Link: https://lore.kernel.org/r/20240830-vfs-file-f_version-v1-18-6d3e4816aa7b@kernel.org
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/file_table.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/fs/file_table.c b/fs/file_table.c index 3ef558f27a1c..7ce4d5dac080 100644 --- a/fs/file_table.c +++ b/fs/file_table.c @@ -156,6 +156,13 @@ static int init_file(struct file *f, int flags, const struct cred *cred) } spin_lock_init(&f->f_lock); + /* + * Note that f_pos_lock is only used for files raising + * FMODE_ATOMIC_POS and directories. Other files such as pipes + * don't need it and since f_pos_lock is in a union may reuse + * the space for other purposes. They are expected to initialize + * the respective member when opening the file. + */ mutex_init(&f->f_pos_lock); f->f_flags = flags; f->f_mode = OPEN_FMODE(flags); |