aboutsummaryrefslogtreecommitdiff
path: root/fs/jbd2/commit.c
diff options
context:
space:
mode:
authorSerge Hallyn <[email protected]>2008-02-29 15:14:57 +0000
committerLinus Torvalds <[email protected]>2008-03-20 09:46:36 -0700
commitaedb60a67c10a0861af179725d060765262ba0fb (patch)
tree4a4a316f9f7d1ab0bf4da2cdd5c802bfb05c947f /fs/jbd2/commit.c
parent457fb605834504af294916411be128a9b21fc3f6 (diff)
file capabilities: remove cap_task_kill()
The original justification for cap_task_kill() was as follows: check_kill_permission() does appropriate uid equivalence checks. However with file capabilities it becomes possible for an unprivileged user to execute a file with file capabilities resulting in a more privileged task with the same uid. However now that cap_task_kill() always returns 0 (permission granted) when p->uid==current->uid, the whole hook is worthless, and only likely to create more subtle problems in the corner cases where it might still be called but return -EPERM. Those cases are basically when uids are different but euid/suid is equivalent as per the check in check_kill_permission(). One example of a still-broken application is 'at' for non-root users. This patch removes cap_task_kill(). Signed-off-by: Serge Hallyn <[email protected]> Acked-by: Andrew G. Morgan <[email protected]> Earlier-version-tested-by: Luiz Fernando N. Capitulino <[email protected]> Acked-by: Casey Schaufler <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'fs/jbd2/commit.c')
0 files changed, 0 insertions, 0 deletions