aboutsummaryrefslogtreecommitdiff
path: root/fs/jbd2/commit.c
diff options
context:
space:
mode:
authorAlex Elder <[email protected]>2012-08-10 13:12:10 -0700
committerAlex Elder <[email protected]>2012-10-01 14:30:53 -0500
commit02cdb02ceab1f3dd9ac2bc899fc51f0e0e744782 (patch)
tree0f9d8c79fa2eaab44a969592d5cf189bd82bf7c7 /fs/jbd2/commit.c
parent589d30e0b3e649e2660f9a67be88e235b28bc319 (diff)
rbd: kill create_snap sysfs entry
Josh proposed the following change, and I don't think I could explain it any better than he did: From: Josh Durgin <[email protected]> Date: Tue, 24 Jul 2012 14:22:11 -0700 To: ceph-devel <[email protected]> Message-ID: <[email protected]> Right now the kernel still has one piece of rbd management duplicated from the rbd command line tool: snapshot creation. There's nothing special about snapshot creation that makes it advantageous to do from the kernel, so I'd like to remove the create_snap sysfs interface. That is, /sys/bus/rbd/devices/<id>/create_snap would be removed. Does anyone rely on the sysfs interface for creating rbd snapshots? If so, how hard would it be to replace with: rbd snap create pool/image@snap Is there any benefit to the sysfs interface that I'm missing? Josh This patch implements this proposal, removing the code that implements the "snap_create" sysfs interface for rbd images. As a result, quite a lot of other supporting code goes away. Suggested-by: Josh Durgin <[email protected]> Signed-off-by: Alex Elder <[email protected]> Reviewed-by: Josh Durgin <[email protected]>
Diffstat (limited to 'fs/jbd2/commit.c')
0 files changed, 0 insertions, 0 deletions