diff options
author | Eric Dumazet <[email protected]> | 2015-02-27 18:35:35 -0800 |
---|---|---|
committer | David S. Miller <[email protected]> | 2015-02-28 23:57:19 -0500 |
commit | 2f1d8b9e8afa5a833d96afcd23abcb8cdf8d83ab (patch) | |
tree | 12dbce95e244af612094c4cc7aa8e7ed0ab46755 /fs/jbd/commit.c | |
parent | 32034e0580a9cd8cebd303ced20f54c06cb24f4d (diff) |
macvtap: make sure neighbour code can push ethernet header
Brian reported crashes using IPv6 traffic with macvtap/veth combo.
I tracked the crashes in neigh_hh_output()
-> memcpy(skb->data - HH_DATA_MOD, hh->hh_data, HH_DATA_MOD);
Neighbour code assumes headroom to push Ethernet header is
at least 16 bytes.
It appears macvtap has only 14 bytes available on arches
where NET_IP_ALIGN is 0 (like x86)
Effect is a corruption of 2 bytes right before skb->head,
and possible crashes if accessing non existing memory.
This fix should also increase IPv4 performance, as paranoid code
in ip_finish_output2() wont have to call skb_realloc_headroom()
Reported-by: Brian Rak <[email protected]>
Tested-by: Brian Rak <[email protected]>
Signed-off-by: Eric Dumazet <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'fs/jbd/commit.c')
0 files changed, 0 insertions, 0 deletions