diff options
author | Kevin Hilman <[email protected]> | 2009-10-26 16:50:18 -0700 |
---|---|---|
committer | Linus Torvalds <[email protected]> | 2009-10-29 07:39:31 -0700 |
commit | 246eb7f0ed1a8aeddec5313137767658f378949b (patch) | |
tree | 25cfbdab4d133ebb1539b3c8b4e302f1ca7866b3 /fs/jbd/commit.c | |
parent | 5e8d8f6f2844d4a663415c660ab5cc92e2e2477d (diff) |
cpuidle: always return with interrupts enabled
In the case where cpuidle_idle_call() returns before changing state due to
a need_resched(), it was returning with IRQs disabled.
The idle path assumes that the platform specific idle code returns with
interrupts enabled (although this too is undocumented AFAICT) and on ARM
we have a WARN_ON(!(irqs_disabled()) when returning from the idle loop, so
the user-visible effects were only a warning since interrupts were
eventually re-enabled later.
On x86, this same problem exists, but there is no WARN_ON() to detect it.
As on ARM, the interrupts are eventually re-enabled, so I'm not sure of
any actual bugs triggered by this. It's primarily a
correctness/consistency fix.
This patch ensures IRQs are (re)enabled before returning.
Reported-by: Hemanth V <[email protected]>
Signed-off-by: Kevin Hilman <[email protected]>
Cc: Arjan van de Ven <[email protected]>
Cc: Len Brown <[email protected]>
Cc: Venkatesh Pallipadi <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: "Rafael J. Wysocki" <[email protected]>
Tested-by: Martin Michlmayr <[email protected]>
Cc: <[email protected]> [2.6.31.x]
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'fs/jbd/commit.c')
0 files changed, 0 insertions, 0 deletions