diff options
| author | Wei Yongjun <weiyongjun1@huawei.com> | 2018-07-27 07:15:15 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-07-28 09:26:31 +0200 |
| commit | 6d4abf1c0e265d8e99c155b91c1cf44e37793e53 (patch) | |
| tree | 66f2cc0e5646871b93ec0da0ef9d8220d08b52c9 /drivers | |
| parent | 758c579ec631ce5efd8de3d3d35483416ae2cad1 (diff) | |
staging: axis-fifo: fix return value check in axis_fifo_probe()
In case of error, the function device_create() returns ERR_PTR() and
never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().
Fixes: 4a965c5f89de ("staging: add driver for Xilinx AXI-Stream FIFO v4.1 IP core")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/staging/axis-fifo/axis-fifo.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c index 2a73302620ec..51a081df5741 100644 --- a/drivers/staging/axis-fifo/axis-fifo.c +++ b/drivers/staging/axis-fifo/axis-fifo.c @@ -1006,10 +1006,10 @@ static int axis_fifo_probe(struct platform_device *pdev) /* create driver file */ fifo->device = device_create(axis_fifo_driver_class, NULL, fifo->devt, NULL, device_name); - if (!fifo->device) { + if (IS_ERR(fifo->device)) { dev_err(fifo->dt_device, "couldn't create driver file\n"); - rc = -ENOMEM; + rc = PTR_ERR(fifo->device); goto err_chrdev_region; } dev_set_drvdata(fifo->device, fifo); |