diff options
author | Lee Jones <lee@kernel.org> | 2023-12-13 16:42:34 +0000 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-12-15 13:55:29 +0100 |
commit | d32dcb0659bcb3b68878a985280024ec92d0db5b (patch) | |
tree | bc7b1cea144aa2bf075cb0cd9fa19d98bfb9a3b2 /drivers/usb/gadget/udc/cdns2/cdns2-debug.h | |
parent | 0d12c1cca7883620b1888ce4b892a9ed27bf3682 (diff) |
usb: gadget: udc: atmel: Replace snprintf() with the safer scnprintf() variant
There is a general misunderstanding amongst engineers that {v}snprintf()
returns the length of the data *actually* encoded into the destination
array. However, as per the C99 standard {v}snprintf() really returns
the length of the data that *would have been* written if there were
enough space for it. This misunderstanding has led to buffer-overruns
in the past. It's generally considered safer to use the {v}scnprintf()
variants in their place (or even sprintf() in simple cases). So let's
do that.
Link: https://lwn.net/Articles/69419/
Link: https://github.com/KSPP/linux/issues/105
Cc: Cristian Birsan <cristian.birsan@microchip.com>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Claudiu Beznea <claudiu.beznea@tuxon.dev>
Cc: <linux-arm-kernel@lists.infradead.org>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20231213164246.1021885-6-lee@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/gadget/udc/cdns2/cdns2-debug.h')
0 files changed, 0 insertions, 0 deletions