diff options
| author | Greg Kroah-Hartman <[email protected]> | 2023-06-15 11:30:35 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2023-06-15 11:30:35 +0200 |
| commit | df49f2a0ac4a34c0cb4b5c233fcfa0add644c43c (patch) | |
| tree | bf3c392454f5767bd68aca8c5db34cf699c4d29d /drivers/usb/common | |
| parent | 53d061c19dc4cb68409df6dc11c40389c8c42a75 (diff) | |
Revert "usb: common: usb-conn-gpio: Set last role to unknown before initial detection"
This reverts commit edd60d24bd858cef165274e4cd6cab43bdc58d15.
Heikki reports that this should not be a global flag just to work around
one broken driver and should be fixed differently, so revert it.
Reported-by: Heikki Krogerus <[email protected]>
Fixes: edd60d24bd85 ("usb: common: usb-conn-gpio: Set last role to unknown before initial detection")
Link: https://lore.kernel.org/r/[email protected]
Cc: Prashanth K <[email protected]>
Cc: AngeloGioacchino Del Regno <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'drivers/usb/common')
| -rw-r--r-- | drivers/usb/common/usb-conn-gpio.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/usb/common/usb-conn-gpio.c b/drivers/usb/common/usb-conn-gpio.c index d0e8624c7dfe..766005d20bae 100644 --- a/drivers/usb/common/usb-conn-gpio.c +++ b/drivers/usb/common/usb-conn-gpio.c @@ -257,9 +257,6 @@ static int usb_conn_probe(struct platform_device *pdev) platform_set_drvdata(pdev, info); device_set_wakeup_capable(&pdev->dev, true); - /* Set last role to unknown before performing the initial detection */ - info->last_role = USB_ROLE_UNKNOWN; - /* Perform initial detection */ usb_conn_queue_dwork(info, 0); |