diff options
| author | Greg Kroah-Hartman <[email protected]> | 2023-06-15 11:30:35 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2023-06-15 11:30:35 +0200 |
| commit | df49f2a0ac4a34c0cb4b5c233fcfa0add644c43c (patch) | |
| tree | bf3c392454f5767bd68aca8c5db34cf699c4d29d /drivers/usb/cdns3 | |
| parent | 53d061c19dc4cb68409df6dc11c40389c8c42a75 (diff) | |
Revert "usb: common: usb-conn-gpio: Set last role to unknown before initial detection"
This reverts commit edd60d24bd858cef165274e4cd6cab43bdc58d15.
Heikki reports that this should not be a global flag just to work around
one broken driver and should be fixed differently, so revert it.
Reported-by: Heikki Krogerus <[email protected]>
Fixes: edd60d24bd85 ("usb: common: usb-conn-gpio: Set last role to unknown before initial detection")
Link: https://lore.kernel.org/r/[email protected]
Cc: Prashanth K <[email protected]>
Cc: AngeloGioacchino Del Regno <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'drivers/usb/cdns3')
| -rw-r--r-- | drivers/usb/cdns3/core.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c index 69d2921f2d3b..dbcdf3b24b47 100644 --- a/drivers/usb/cdns3/core.c +++ b/drivers/usb/cdns3/core.c @@ -252,8 +252,6 @@ static enum usb_role cdns_hw_role_state_machine(struct cdns *cdns) if (!vbus) role = USB_ROLE_NONE; break; - default: - break; } dev_dbg(cdns->dev, "role %d -> %d\n", cdns->role, role); |