aboutsummaryrefslogtreecommitdiff
path: root/drivers/usb/cdns3/cdnsp-debug.h
diff options
context:
space:
mode:
authorMathias Nyman <mathias.nyman@linux.intel.com>2023-12-01 17:06:47 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-12-04 07:50:40 +0100
commite2e2aacf042f52854c92775b7800ba668e0bdfe4 (patch)
tree21989b2474be1b90e2bdd0f5730d13540c587ea4 /drivers/usb/cdns3/cdnsp-debug.h
parente34900f46cd69b2859b9894275415134a0988d9d (diff)
xhci: fix possible null pointer deref during xhci urb enqueue
There is a short gap between urb being submitted and actually added to the endpoint queue (linked). If the device is disconnected during this time then usb core is not yet aware of the pending urb, and device may be freed just before xhci_urq_enqueue() continues, dereferencing the freed device. Freeing the device is protected by the xhci spinlock, so make sure we take and keep the lock while checking that device exists, dereference it, and add the urb to the queue. Remove the unnecessary URB check, usb core checks it before calling xhci_urb_enqueue() Suggested-by: Kuen-Han Tsai <khtsai@google.com> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com> Link: https://lore.kernel.org/r/20231201150647.1307406-20-mathias.nyman@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/cdns3/cdnsp-debug.h')
0 files changed, 0 insertions, 0 deletions