aboutsummaryrefslogtreecommitdiff
path: root/drivers/usb/cdns3/cdns3-trace.c
diff options
context:
space:
mode:
authorJiri Slaby (SUSE) <[email protected]>2024-04-16 07:48:25 +0200
committerGreg Kroah-Hartman <[email protected]>2024-04-16 09:05:43 +0200
commit35fad98ed25ab9e08c4363f0f74efd612c8eb185 (patch)
tree70e7caf77914d93a192081ddb48fd87d3cb17eb9 /drivers/usb/cdns3/cdns3-trace.c
parentb20172ca6bf489534892b801a5db41bbf5ceec75 (diff)
serial: meson+qcom: don't advance the kfifo twice
Marek reports, that the -next commit 1788cf6a91d9 (tty: serial: switch from circ_buf to kfifo) broke meson_uart and qcom_geni_serial. The commit mistakenly advanced the kfifo twice: once by uart_fifo_get()/kfifo_out() and second time by uart_xmit_advance(). To advance the fifo only once, drop the superfluous uart_xmit_advance() from both. To count the TX statistics properly, use uart_fifo_out() in qcom_geni_serial (meson_uart_start_tx() already uses that). I checked all other uses of uart_xmit_advance() and they appear correct: either they are finishing DMA transfers or are after peek/linear_ptr (i.e. they do not advance fifo). Signed-off-by: Jiri Slaby (SUSE) <[email protected]> Reported-by: Marek Szyprowski <[email protected]> Fixes: 1788cf6a91d9 ("tty: serial: switch from circ_buf to kfifo") Cc: Neil Armstrong <[email protected]> Cc: Kevin Hilman <[email protected]> Cc: Jerome Brunet <[email protected]> Cc: Martin Blumenstingl <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'drivers/usb/cdns3/cdns3-trace.c')
0 files changed, 0 insertions, 0 deletions